Allow too many arguments lint.

It's just not a useful lint - we should rely on users to decide what to
do in each circumstance.

Bug: 528225104
Change-Id: Id078825ea7251e2ed15da4ad340d13c86a6a6964
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/24620
Commit-Queue: Matt Stark <msta@google.com>
Reviewed-by: Takuto Ikuta <tikuta@google.com>

src/gn/starlark/Cargo.toml

diff --git a/src/gn/starlark/Cargo.toml b/src/gn/starlark/Cargo.toml
index 2072cdd..f534d77 100644
--- a/src/gn/starlark/Cargo.toml
+++ b/src/gn/starlark/Cargo.toml
@@ -89,6 +89,8 @@
 semicolon_if_nothing_returned = "warn"
 single_char_pattern = "warn"
 stable_sort_primitive = "warn"
+# This just isn't a particularly useful lint. We should let users be the judge.
+too_many_arguments = "allow"
 uninlined_format_args = "warn"
 unnecessary_literal_bound = "warn"
 unnecessary_semicolon = "warn"

src/gn/starlark/crates/args/src/args.rs

diff --git a/src/gn/starlark/crates/args/src/args.rs b/src/gn/starlark/crates/args/src/args.rs
index 98165ee..af95fa5 100644
--- a/src/gn/starlark/crates/args/src/args.rs
+++ b/src/gn/starlark/crates/args/src/args.rs
@@ -296,9 +296,6 @@
         Ok(this)
     }
 
-    // Clippy allow: Many arguments are required to match Starlark's Args.add_all
-    // API.
-    #[allow(clippy::too_many_arguments)]
     fn add_all<'v>(
         this: Value<'v>,
         arg_name_or_values: Value<'v>,
@@ -334,9 +331,6 @@
         Ok(this)
     }
 
-    // Clippy allow: Many arguments are required to match Starlark's Args.add_joined
-    // API.
-    #[allow(clippy::too_many_arguments)]
     fn add_joined<'v>(
         this: Value<'v>,
         arg_name_or_values: Value<'v>,

src/gn/starlark/crates/attr/src/globals.rs

diff --git a/src/gn/starlark/crates/attr/src/globals.rs b/src/gn/starlark/crates/attr/src/globals.rs
index e483de9..70b457e 100644
--- a/src/gn/starlark/crates/attr/src/globals.rs
+++ b/src/gn/starlark/crates/attr/src/globals.rs
@@ -125,7 +125,6 @@
         )
     }
 
-    #[allow(clippy::too_many_arguments)]
     fn label<'v>(
         #[starlark(this)] this: &AttrModule,
         #[starlark(require = named)] default: Option<Value<'v>>,
@@ -174,7 +173,6 @@
         )
     }
 
-    #[allow(clippy::too_many_arguments)]
     fn label_list<'v>(
         #[starlark(this)] this: &AttrModule,
         #[starlark(require = named)] default: Option<Value<'v>>,
@@ -200,7 +198,6 @@
         )
     }
 
-    #[allow(clippy::too_many_arguments)]
     fn label_list_dict<'v>(
         #[starlark(this)] this: &AttrModule,
         #[starlark(require = named)] default: Option<Value<'v>>,
@@ -269,7 +266,6 @@
         )
     }
 
-    #[allow(clippy::too_many_arguments)]
     fn string_keyed_label_dict<'v>(
         #[starlark(this)] this: &AttrModule,
         #[starlark(require = named)] default: Option<Value<'v>>,

src/gn/starlark/crates/ffi/src/bridge.rs

diff --git a/src/gn/starlark/crates/ffi/src/bridge.rs b/src/gn/starlark/crates/ffi/src/bridge.rs
index 28ae838..337265a 100644
--- a/src/gn/starlark/crates/ffi/src/bridge.rs
+++ b/src/gn/starlark/crates/ffi/src/bridge.rs
@@ -73,7 +73,6 @@
         #[allow(dead_code)]
         pub(in crate::err) fn ErrToString(err: &Err) -> String;
 
-        #[allow(clippy::too_many_arguments)]
         pub(in crate::err) fn PopulateErrWithLocation(
             err: Pin<&mut Err>,
             message: &str,