|author||Brett Wilson <firstname.lastname@example.org>||Wed May 22 10:32:29 2019 -0700|
|committer||Commit Bot <email@example.com>||Mon Jun 17 17:47:57 2019 +0000|
Update to more uses of C++11. Adds move constructors to some fundamental types such as SourceFile, SourceDir, and Label. Removes most uses of swap and custom swap definitions in favor of move semantics. Converts most default class member initialization to declare default values in the definition. Moves more to using implicit and defaulted-in-the-header constructors and destructors. The previous style was inherited from Chrome which had those rules out of concern for code size. But for this small project the header-based ones are a little easier to follow. Change-Id: I7d5c3bd4ac9863c34b1072fdefef81e59e555a7f Reviewed-on: https://gn-review.googlesource.com/c/gn/+/5080 Commit-Queue: Brett Wilson <firstname.lastname@example.org> Reviewed-by: Scott Graham <email@example.com>
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that
lib.exe can be found in
PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is
clang++, a recent version is expected to be found in
PATH. This can be overridden by setting
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.