commit 9cd5057b6b62ec23fc42ee6335f042a90650393e
author Roland McGrath <mcgrathr@google.com> Fri Jun 29 13:31:16 2018 -0700
committer Commit Bot <commit-bot@chromium.org> Fri Jun 29 20:40:21 2018 +0000
tree 70df1f7d1b85c40163467cd4b99c4d58f16425a9
parent 3ddcf64a362aa4b79e6b950901cd6dacc4dfabb1

[recipes] Add --tags to git fetch command

This ensures that `git describe` will work.

Change-Id: Ie4baef261d0fba2913d08d2bd193f4a1f7e43985
Reviewed-on: https://gn-review.googlesource.com/2021
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

infra/recipes/gn.expected/ci.json

diff --git a/infra/recipes/gn.expected/ci.json b/infra/recipes/gn.expected/ci.json
index 8556002..e2e8933 100644
--- a/infra/recipes/gn.expected/ci.json
+++ b/infra/recipes/gn.expected/ci.json
@@ -19,6 +19,7 @@
     "cmd": [
       "git",
       "fetch",
+      "--tags",
       "https://gn.googlesource.com/gn",
       "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
     ],

infra/recipes/gn.expected/cipd_exists.json

diff --git a/infra/recipes/gn.expected/cipd_exists.json b/infra/recipes/gn.expected/cipd_exists.json
index 8dfe0f6..5a7f14a 100644
--- a/infra/recipes/gn.expected/cipd_exists.json
+++ b/infra/recipes/gn.expected/cipd_exists.json
@@ -19,6 +19,7 @@
     "cmd": [
       "git",
       "fetch",
+      "--tags",
       "https://gn.googlesource.com/gn",
       "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
     ],

infra/recipes/gn.expected/cipd_register.json

diff --git a/infra/recipes/gn.expected/cipd_register.json b/infra/recipes/gn.expected/cipd_register.json
index ffdcfa5..5a31ae9 100644
--- a/infra/recipes/gn.expected/cipd_register.json
+++ b/infra/recipes/gn.expected/cipd_register.json
@@ -19,6 +19,7 @@
     "cmd": [
       "git",
       "fetch",
+      "--tags",
       "https://gn.googlesource.com/gn",
       "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
     ],

infra/recipes/gn.expected/cq.json

diff --git a/infra/recipes/gn.expected/cq.json b/infra/recipes/gn.expected/cq.json
index 71cb320..e9b8b25 100644
--- a/infra/recipes/gn.expected/cq.json
+++ b/infra/recipes/gn.expected/cq.json
@@ -19,6 +19,7 @@
     "cmd": [
       "git",
       "fetch",
+      "--tags",
       "https://gn.googlesource.com/gn",
       "refs/heads/master"
     ],

infra/recipes/gn.py

diff --git a/infra/recipes/gn.py b/infra/recipes/gn.py
index df9d6e2..0a88862 100644
--- a/infra/recipes/gn.py
+++ b/infra/recipes/gn.py
@@ -36,7 +36,8 @@
       ref = (
           build_input.gitiles_commit.id
           if build_input.gitiles_commit else 'refs/heads/master')
-      api.step('fetch', ['git', 'fetch', repository, ref])
+      # Fetch tags so `git describe` works.
+      api.step('fetch', ['git', 'fetch', '--tags', repository, ref])
       api.step('checkout', ['git', 'checkout', 'FETCH_HEAD'])
       for change in build_input.gerrit_changes:
         api.step('fetch %s/%s' % (change.change, change.patchset), [