commit af6b854c5b4b4d00f1c17a1a5c04b7c0cc8a2288
author Michał Pichliński <mpichlinski@opera.com> Thu Apr 12 12:45:14 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Apr 12 12:45:14 2018 +0000
tree b5b423a7582c2b7a1c54e690f68ff3578c47aeb8
parent 69534a0a3ce7cadf5ac9d82032a072889eac8090

GN: Allow XCode projects to use ICECC environment variables.

Without them XCode cannot compile generated projects with ICECC.

Bug: 831500
Change-Id: I3b50c730660c4e8a6a06b9fda340e20edb87e40a
Reviewed-on: https://chromium-review.googlesource.com/1006577
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Michal Pichlinski <mpichlinski@opera.com>
Cr-Original-Commit-Position: refs/heads/master@{#550159}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5208b8e8bb6ba0038016d17abac6911f3067b088

tools/gn/xcode_writer.cc

diff --git a/tools/gn/xcode_writer.cc b/tools/gn/xcode_writer.cc
index f5dd65a..37c23e2 100644
--- a/tools/gn/xcode_writer.cc
+++ b/tools/gn/xcode_writer.cc
@@ -48,9 +48,13 @@
 };
 
 SafeEnvironmentVariableInfo kSafeEnvironmentVariables[] = {
-    {"HOME", true}, {"LANG", true},    {"PATH", true},
-    {"USER", true}, {"TMPDIR", false},
-};
+    {"HOME", true},
+    {"LANG", true},
+    {"PATH", true},
+    {"USER", true},
+    {"TMPDIR", false},
+    {"ICECC_VERSION", true},
+    {"ICECC_CLANG_REMOTE_CPP", true}};
 
 XcodeWriter::TargetOsType GetTargetOs(const Args& args) {
   const Value* target_os_value = args.GetArgOverride(variables::kTargetOs);