commit b2d77ab1373192d1532af94b68fb8bab727b0e5b
author Tyler Mandry <tmandry@google.com> Sat Jul 17 00:27:45 2021 +0000
committer Commit Bot <commit-bot@chromium.org> Sat Jul 17 05:19:15 2021 +0000
tree 5f70d9fc8953b95ef63fec832fa211e45e49bc24
parent 6c6885302fd94f41b060013ea94eeb0d886124e2

[rust] Clean up logic in PullDependentTargetLibsFrom

This code copies native libraries from a target's transitive_libs to
inherited_libs. It applied is_public of the current dependency to each
copied library, which isn't necessary. In practice this had no effect,
but removing this makes it more obvious what's going on.

Change-Id: I40f05a836291998a122c1a881e7b543c40aae39f
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/12002
Reviewed-by: Petr Hosek <phosek@google.com>
Commit-Queue: Petr Hosek <phosek@google.com>

src/gn/target.cc

diff --git a/src/gn/target.cc b/src/gn/target.cc
index 5600f46..f9e063b 100644
--- a/src/gn/target.cc
+++ b/src/gn/target.cc
@@ -677,8 +677,7 @@
          rust_values().transitive_libs().GetOrderedAndPublicFlag()) {
       if (!(inherited.first->output_type() == RUST_LIBRARY ||
             inherited.first->output_type() == RUST_PROC_MACRO)) {
-        inherited_libraries_.Append(inherited.first,
-                                    is_public && inherited.second);
+        inherited_libraries_.Append(inherited.first, inherited.second);
       }
     }
   } else if (dep->output_type() == RUST_PROC_MACRO) {