commit ce8f166ca2f755ddecd9711f915774055f67e388
author Tom Anderson <thomasanderson@chromium.org> Fri May 18 15:26:34 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Fri May 18 15:26:34 2018 +0000
tree d710681602dab0518b11ef24b8334eb49f31bc89
parent 896cddb9888aeb5c0262effa27d38c06edbaeade

Fix gn CHECK()ing on not_needed() when given undefined identifiers

GN now gives an error message that looks like:

ERROR at //BUILD.gn:76:23: Undefined identifier
  not_needed(["deps", "deps_____________"])
                      ^------------------

R=dpranke

Change-Id: Ic55afef672a7aefab7934875ceb22aff52b68f94
Reviewed-on: https://chromium-review.googlesource.com/1063118
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#559899}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4497a44f0d8236cb069ed89c013154c1adfc2087

tools/gn/functions.cc

diff --git a/tools/gn/functions.cc b/tools/gn/functions.cc
index 105dadf..e7fb524 100644
--- a/tools/gn/functions.cc
+++ b/tools/gn/functions.cc
@@ -746,7 +746,10 @@
     for (const Value& cur : value->list_value()) {
       if (!cur.VerifyTypeIs(Value::STRING, err))
         return Value();
-      source->MarkUsed(cur.string_value());
+      if (!source->GetValue(cur.string_value(), true)) {
+        *err = Err(cur, "Undefined identifier");
+        return Value();
+      }
     }
     return Value();
   }