| commit | dcab2f94a3e5f1e52e4f030becfbf138117c7b8c | [log] [tgz] |
|---|---|---|
| author | Sylvain Defresne <sdefresne@chromium.org> | Wed Apr 03 16:34:05 2019 +0200 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Apr 03 15:12:37 2019 +0000 |
| tree | a99ea8309fbb172ecbb60bfb247ba6cc981d5d1c | |
| parent | d46f92f4465be387dcf96fd6be070e8791b59763 [diff] |
Fix issues with bundle_data/create_bundle targets
Remove the bundle_plugins_dir variable as it is not really required
(the value is always the same for both iOS and macOS) and the value
can be inlined instead ({{bundle_contents_dir}}/Plugins).
Fix NinjaCreateBundleTargetWriter to only complain about missing
compile_xcassets tool if the target require it (i.e. if it defines
a list of resources to compile in an asset catalog).
Fix incorrect use of deps instead of public_deps in bundle_data
documentation.
Bug: https://bugs.chromium.org/p/gn/issues/detail?id=64
Change-Id: I28a0a3d673dc1b39804c466499e6e91f034a2113
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/4480
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.
You can download the latest version of GN binary for Linux, macOS and Windows.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe, link.exe, and lib.exe can be found in PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++, a recent version is expected to be found in PATH. This can be overridden by setting CC, CXX, and AR.
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.