commit e9183c8001b133b441ef52ccf59b163b71be90b5
author Brett Wilson <brettw@chromium.org> Thu Nov 30 22:07:32 2017 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Nov 30 22:07:32 2017 +0000
tree 039aa226033a3a781f6c56fa4d49f33f1d633cfd
parent b0c49f11423bda3c0c1a6885bf73746b096de582

Remove base::SizeToToString[16]

Convert to overloaded variant base::NumberToString

Add SECURITY_OWNERS owner for
components/network_hints/common/network_hints_messages.cc

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I1bae6619c1da5c1cf32cbbdc2fe82946e355d74f
Reviewed-on: https://chromium-review.googlesource.com/799550
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#520710}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5accd24a54176bb699e22604f9b95ab82a016545

tools/gn/command_gen.cc

diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc
index 5775f78..67ac18a 100644
--- a/tools/gn/command_gen.cc
+++ b/tools/gn/command_gen.cc
@@ -462,12 +462,12 @@
     for (const auto& rules : write_info.rules)
       targets_collected += rules.second.size();
 
-    std::string stats = "Made " + base::SizeTToString(targets_collected) +
-        " targets from " +
+    std::string stats =
+        "Made " + base::NumberToString(targets_collected) + " targets from " +
         base::IntToString(
             setup->scheduler().input_file_manager()->GetInputFileCount()) +
-        " files in " +
-        base::Int64ToString(elapsed_time.InMilliseconds()) + "ms\n";
+        " files in " + base::Int64ToString(elapsed_time.InMilliseconds()) +
+        "ms\n";
     OutputString(stats);
   }
 

tools/gn/parse_tree.cc

diff --git a/tools/gn/parse_tree.cc b/tools/gn/parse_tree.cc
index 382d575..df95bf5 100644
--- a/tools/gn/parse_tree.cc
+++ b/tools/gn/parse_tree.cc
@@ -250,9 +250,9 @@
   size_t index_sizet = static_cast<size_t>(index_int);
   if (index_sizet >= max_len) {
     *err = Err(index_->GetRange(), "Array subscript out of range.",
-        "You gave me " + base::Int64ToString(index_int) +
-        " but I was expecting something from 0 to " +
-        base::SizeTToString(max_len) + ", inclusive.");
+               "You gave me " + base::Int64ToString(index_int) +
+                   " but I was expecting something from 0 to " +
+                   base::NumberToString(max_len) + ", inclusive.");
     return false;
   }
 

tools/gn/substitution_pattern.cc

diff --git a/tools/gn/substitution_pattern.cc b/tools/gn/substitution_pattern.cc
index 940456e..756200c 100644
--- a/tools/gn/substitution_pattern.cc
+++ b/tools/gn/substitution_pattern.cc
@@ -77,9 +77,8 @@
       // most people will not be writing substitution patterns and the code
       // to exactly indicate the error location is tricky.
       *err = Err(origin, "Unknown substitution pattern",
-          "Found a {{ at offset " +
-          base::SizeTToString(next) +
-          " and did not find a known substitution following it.");
+                 "Found a {{ at offset " + base::NumberToString(next) +
+                     " and did not find a known substitution following it.");
       ranges_.clear();
       return false;
     }