commit f558beedd72a22cec1f65833b9ab99387ce6b7c0
author Bruce Dawson <brucedawson@chromium.org> Wed Sep 27 21:21:32 2017 +0000
committer Commit Bot <commit-bot@chromium.org> Wed Sep 27 21:21:32 2017 +0000
tree f7ddec65e3480ac018eb60fc555dfd34a56641f4
parent aa0e14ce8d16d031b646a6a1d9bf827b5a89cee3

Require Creators Update SDK to build Chrome on Windows

There is an increasing need to use Windows features that only exist in
Windows 10 Creators Update or later. This is most conveniently done by
requiring that SDK. The packaged toolchain used by Google build machines
and Google employees has been using the Creators Update SDK for several
months - this CL only changes the requirement for those who are not
using the packaged toolchain. This update would have been done earlier
but several broken versions of the Creators Update SDK necessitated a
delay.

This change was triggered by crrev.com/c/649026 which had to be reverted
due to its dependence on the Creators Update SDK. This change will let
that change be relanded. Requiring the Creators Update SDK will also
allow ENABLE_HDR_DETECTION to be unconditionally defined.

After this change developers will get an informative error message if
they do not have the Creators Update SDK or later installed.

Note that Chrome, of course, still needs to *run* on versions of Windows
before Windows 10 Creators Update - this just covers *build*
requirements.

Bug: 760977
Change-Id: Ice36177e25cedb80555a3ebedaf9f710cafb1a88
Reviewed-on: https://chromium-review.googlesource.com/666023
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504773}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fb0b9d315f449c822f61de545a67b4c3b14c6e60

tools/gn/visual_studio_writer.cc

diff --git a/tools/gn/visual_studio_writer.cc b/tools/gn/visual_studio_writer.cc
index 7c6a245..ad821a7 100644
--- a/tools/gn/visual_studio_writer.cc
+++ b/tools/gn/visual_studio_writer.cc
@@ -79,7 +79,7 @@
 const char kVersionStringVs2015[] = "Visual Studio 2015";  // Visual Studio 2015
 const char kVersionStringVs2017[] = "Visual Studio 2017";  // Visual Studio 2017
 const char kWindowsKitsVersion[] = "10";                   // Windows 10 SDK
-const char kWindowsKitsDefaultVersion[] = "10.0.14393.0";  // Windows 10 SDK
+const char kWindowsKitsDefaultVersion[] = "10.0.15063.0";  // Windows 10 SDK
 
 const char kGuidTypeProject[] = "{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}";
 const char kGuidTypeFolder[] = "{2150E333-8FDC-42A3-9474-1A3956D46DE8}";

tools/gn/visual_studio_writer_unittest.cc

diff --git a/tools/gn/visual_studio_writer_unittest.cc b/tools/gn/visual_studio_writer_unittest.cc
index 1ad7c61..6a7fbfc 100644
--- a/tools/gn/visual_studio_writer_unittest.cc
+++ b/tools/gn/visual_studio_writer_unittest.cc
@@ -29,7 +29,7 @@
 TEST_F(VisualStudioWriterTest, ResolveSolutionFolders) {
   VisualStudioWriter writer(setup_.build_settings(), "Win32",
                             VisualStudioWriter::Version::Vs2015,
-                            "10.0.14393.0");
+                            "10.0.15063.0");
 
   std::string path =
       MakeTestPath("/foo/chromium/src/out/Debug/obj/base/base.vcxproj");
@@ -84,7 +84,7 @@
 TEST_F(VisualStudioWriterTest, ResolveSolutionFolders_AbsPath) {
   VisualStudioWriter writer(setup_.build_settings(), "Win32",
                             VisualStudioWriter::Version::Vs2015,
-                            "10.0.14393.0");
+                            "10.0.15063.0");
 
   std::string path =
       MakeTestPath("/foo/chromium/src/out/Debug/obj/base/base.vcxproj");