|author||Julie Hockett <email@example.com>||Mon Jun 24 17:28:22 2019 -0700|
|committer||Commit Bot <firstname.lastname@example.org>||Tue Jun 25 17:09:45 2019 +0000|
Fix linking deps propagation Rust libraries are not final from the perspective of anything depending on them, but we do need to collect all the link lines of their transitive dependencies in each, and so this removes RUST_LIBRARY from the Target::IsFinal() function, but also adds in an if branch to collect dependent linking information in NinjaBinaryTargetWriter::ClassifyDependency(). Bug: crbug/gn/88 Change-Id: I41dddb5fddbddb41a24b6bb3cd3a72fd0fb07159 Reviewed-on: https://gn-review.googlesource.com/c/gn/+/5260 Reviewed-by: Brett Wilson <email@example.com> Commit-Queue: Julie Hockett <firstname.lastname@example.org>
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that
lib.exe can be found in
PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is
clang++, a recent version is expected to be found in
PATH. This can be overridden by setting
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.